Found a few more nits, but once these are addressed lgtm.
https://codereview.chromium.org/164793003/diff/290001/src/a64/code-stubs-a64.cc
File src/a64/code-stubs-a64.cc (right):
https://codereview.chromium.org/164793003/diff/290001/src/a64/code-stubs-a64.cc#newcode4718
src/a64/code-stubs-a64.cc:4718: UseScratchRegisterScope temps(masm);
You don't need this anymore
https://codereview.chromium.org/164793003/diff/290001/src/a64/code-stubs-a64.cc#newcode4782
src/a64/code-stubs-a64.cc:4782: UseScratchRegisterScope temps(masm);
ditto
https://codereview.chromium.org/164793003/diff/290001/src/a64/code-stubs-a64.cc#newcode4826
src/a64/code-stubs-a64.cc:4826: UseScratchRegisterScope temps(masm);
ditto
https://codereview.chromium.org/164793003/diff/290001/src/a64/code-stubs-a64.cc#newcode4860
src/a64/code-stubs-a64.cc:4860: UseScratchRegisterScope temps(masm);
ditto
https://codereview.chromium.org/164793003/diff/290001/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/164793003/diff/290001/src/a64/macro-assembler-a64.cc#newcode4817
src/a64/macro-assembler-a64.cc:4817:
ASSERT(!TmpList()->IncludesAliasOf(arg0));
might be nice to have IncludesAliasOf be a multi-arg function (with
default NoReg args) so you could just do:
ASSERT(!TmpList()->IncludesAliasOf(arg0, arg1, arg2, arg3));
https://codereview.chromium.org/164793003/diff/290001/src/a64/macro-assembler-a64.cc#newcode4829
src/a64/macro-assembler-a64.cc:4829: ASSERT(!AreAliased(arg0,
StackPointer()));
nit -
ASSERT(!AreAliased(StackPointer(), arg0, arg1, arg2, arg3));
(This would prevent passing multiple of the same reg as arguments, but I
don't think we'd need that. If you disagree I'm fine leaving this
as-is).
https://codereview.chromium.org/164793003/diff/290001/src/a64/macro-assembler-a64.h
File src/a64/macro-assembler-a64.h (right):
https://codereview.chromium.org/164793003/diff/290001/src/a64/macro-assembler-a64.h#newcode2212
src/a64/macro-assembler-a64.h:2212:
remove extra newline (only two newlines between functions in cc files,
not class definitions).
https://codereview.chromium.org/164793003/diff/290001/src/a64/macro-assembler-a64.h#newcode2215
src/a64/macro-assembler-a64.h:2215:
ditto
https://codereview.chromium.org/164793003/diff/290001/src/a64/macro-assembler-a64.h#newcode2223
src/a64/macro-assembler-a64.h:2223:
ditto
https://codereview.chromium.org/164793003/diff/290001/src/a64/macro-assembler-a64.h#newcode2227
src/a64/macro-assembler-a64.h:2227:
ditto
https://codereview.chromium.org/164793003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
