https://codereview.chromium.org/201643003/diff/60001/include/v8-util.h
File include/v8-util.h (right):
https://codereview.chromium.org/201643003/diff/60001/include/v8-util.h#newcode46
include/v8-util.h:46: namespace persistent_value_map_traits {
no need for a new namespace
https://codereview.chromium.org/201643003/diff/60001/include/v8-util.h#newcode49
include/v8-util.h:49: class WeakSTLMapTraits {
would be better as StdPersistentValueMap which itself has weak traits,
which default to something which does nothing
https://codereview.chromium.org/201643003/diff/60001/include/v8-util.h#newcode86
include/v8-util.h:86: static const bool kIsWeak = false;
this should be true for a class called WeakSTLMapTraits
https://codereview.chromium.org/201643003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
