looking good, i still don't like the problem with the overrides
https://codereview.chromium.org/201643003/diff/120001/include/v8-util.h
File include/v8-util.h (right):
https://codereview.chromium.org/201643003/diff/120001/include/v8-util.h#newcode87
include/v8-util.h:87: static void Dispose(v8::Isolate* isolate,
v8::UniquePersistent<V> value,
still have the problem that these are overridden in the sublclass
https://codereview.chromium.org/201643003/diff/120001/include/v8-util.h#newcode102
include/v8-util.h:102: /**
2 lines between definitions.
https://codereview.chromium.org/201643003/diff/120001/include/v8-util.h#newcode269
include/v8-util.h:269: /**
again
https://codereview.chromium.org/201643003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
