On 2014/04/03 11:42:34, Toon Verwaest wrote:
That sounds reasonable.
On second thought, please move all of this code to BuildLoadNamedField.
The
rest
of the machinery is there to ensure that all checks are done properly,
and you
*do* need them as well. Suppose the value you are loading comes from the
prototype chain. We are guaranteed that the value doesn't disappear from
its
holder, however, the prototype chain could change; or the property could
appear
in between.
Putting the code in BuildLoadNamedField ensures that all checks are done
properly (and possibly elided) in BuildMonomorphicAccess.
Doesn't LocalLookup (with the false parameter) ensure that the value to be
loaded
was always on the object itself?
https://codereview.chromium.org/220163012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
