Yes you are right, the HCheckMaps is unnecessary in the case it's directly
on
the object. However, that's also true in case the property is in the
prototype
chain. The holder requires no checks, while all objects up to the holder do
need
map-checks (and negative lookups in case of NORMAL).
So I think a better solution is to detect whether the holder needs a check,
and
eliminate the holder-check in case it's read-only non-deletable. But that's
a
separate optimization. I'd (for now) just emit the map-checks.
You are also right about the "normal" object case, I missed that.
https://codereview.chromium.org/220163012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
