https://codereview.chromium.org/325553002/diff/1/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/325553002/diff/1/src/d8.cc#newcode292
src/d8.cc:292: // performance.now() returns a time stamp as double,
measured in milliseconds.
On 2014/06/09 15:23:51, Hannes Payer wrote:
Please adjust the comment, i.e. say what it returns in predictable
mode.
Done.
https://codereview.chromium.org/325553002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/325553002/diff/1/src/flag-definitions.h#newcode877
src/flag-definitions.h:877: DEFINE_bool(allocations_digest, false,
On 2014/06/09 15:23:51, Hannes Payer wrote:
Do we need both, verify_predictable and allocations_digest? It seems
like that
unifying both modes in verify_predictable is good enough?
Done.
https://codereview.chromium.org/325553002/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/325553002/diff/1/src/heap.h#newcode979
src/heap.h:979: // Number of allocations done so far.
On 2014/06/09 15:23:51, Hannes Payer wrote:
"runtime allocations"
Done.
https://codereview.chromium.org/325553002/diff/1/src/heap.h#newcode1563
src/heap.h:1563: uint32_t allocations_count_; // how many allocations
happened
On 2014/06/09 15:23:51, Hannes Payer wrote:
Style guide: Each comment should start in a new line, upper case,
ending with a
".". Since you are here you can also change ms_count_ and gc_count_.
Done.
https://codereview.chromium.org/325553002/diff/1/src/spaces-inl.h
File src/spaces-inl.h (right):
https://codereview.chromium.org/325553002/diff/1/src/spaces-inl.h#newcode274
src/spaces-inl.h:274: heap()->OnAllocationEvent(object, size_in_bytes);
On 2014/06/09 15:23:51, Hannes Payer wrote:
See my comment about Heap::AllocateRaw.
Replied.
https://codereview.chromium.org/325553002/diff/1/src/spaces-inl.h#newcode299
src/spaces-inl.h:299: heap()->OnAllocationEvent(obj, size_in_bytes);
On 2014/06/09 15:23:51, Hannes Payer wrote:
See my comment about Heap::AllocateRaw.
Replied.
https://codereview.chromium.org/325553002/diff/1/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/325553002/diff/1/src/spaces.cc#newcode2901
src/spaces.cc:2901: heap()->OnAllocationEvent(object, object_size);
On 2014/06/09 15:23:51, Hannes Payer wrote:
The event call should be in Heap::AllocateRaw. There is actually
already a call
to profiler->AllocationEvent. This is catching the same event for a
different
purpose. I guess we can refactor there.
I trigger "allocation event" each time any allocation happens (either
object or target place for evacuation), while profiler has to
distinguish between new object creation and object relocation. I think
that for this verification purpose we can keep things simple. WDYT?
https://codereview.chromium.org/325553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
