https://codereview.chromium.org/325553002/diff/1/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/325553002/diff/1/src/spaces.cc#newcode2901
src/spaces.cc:2901: heap()->OnAllocationEvent(object, object_size);
On 2014/06/10 08:22:54, Igor Sheludko wrote:
On 2014/06/09 15:23:51, Hannes Payer wrote:
> The event call should be in Heap::AllocateRaw. There is actually
already a
call
> to profiler->AllocationEvent. This is catching the same event for a
different
> purpose. I guess we can refactor there.
I trigger "allocation event" each time any allocation happens (either
object or
target place for evacuation), while profiler has to distinguish
between new
object creation and object relocation. I think that for this
verification
purpose we can keep things simple. WDYT?
1) Please move your monitoring code into Heap:AllocateRaw. That is our
runtime
allocation choke point.
2) I would assume that it your monitoring call will be at the exact same
location as profiler->AllocationEvent. Hence, re-using this
infrastructure would keep stuff simple.
WDYT?
https://codereview.chromium.org/325553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
