On 2014/06/12 13:39:18, ulan wrote:
[+Ben]
Ben, wdyt about the HObjectAccess comment?
https://codereview.chromium.org/324093002/diff/20001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/324093002/diff/20001/src/hydrogen-instructions.h#newcode6785
src/hydrogen-instructions.h:6785: return true;
Could you please port this to other architectures and get rid of this
function?
https://codereview.chromium.org/324093002/diff/20001/src/hydrogen-instructions.h#newcode6791
src/hydrogen-instructions.h:6791: return !(access.IsExternalMemory() ||
This predicate should be part of HObjectAccess (if Ben doesn't disagree).
We tried to go down this route before, but by simplifying all object
accesses
into a either two loads or a load and a store. That had the disadvantage of
reducing the accuracy of GVN and load/store elimination.
This approach doesn't that have the disadvantage of reducing the accuracy of
those phases, but it further entangles the whole graph with these extra
uses,
that are only used on two backends. That seems like added complexity that
I'm
not sure is worth it.
https://codereview.chromium.org/324093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
