On Thu, Nov 27, 2014 at 1:06 PM, Philip Jägenstedt <phil...@opera.com> wrote:
> On Thu, Nov 27, 2014 at 12:54 PM, Mathias Bynens <mathi...@opera.com> wrote:
>> On Thu, Nov 27, 2014 at 12:52 PM, Philip Jägenstedt <phil...@opera.com> 
>> wrote:
>>> It sure sounds like 'contains' would be less likely to cause trouble,
>>> and is also a slightly better name IMHO.
>>>
>>> Is Mozilla on board with renaming it? If they're not keen, I think
>>> following their lead with 'contains' makes more sense.
>>
>> The renaming of `contains` to `includes` was decided at the recent
>> TC39 meeting: 
>> https://github.com/rwaldron/tc39-notes/blob/master/es6/2014-11/nov-18.md#51--44-arrayprototypecontains-and-stringprototypecontains
>> `contains` was breaking the web (for both `String` and `Array`).
>
> That's really unfortunate, it's going to be silly to have e.g.
> DOMStringList.contains but Array.includes...

Yep. But it is what it is. :(

> What kind of content is breaking, and how has Firefox been able to
> ship with "".contains since November 2012?

https://code.google.com/p/chromium/issues/detail?id=409858 is an example.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to