On Tue, Nov 24, 2015 at 2:11 PM, Chia-Wen Ho <chiawen...@gmail.com> wrote:
> Hi Jakob, > > One interesting point to me here. You mention in "3.32 was just a random > daily snapshot". What kind of objects will be included in the snapshot? > Sorry, I didn't mean that in the "snapshot=off" sense. I meant: "version 3.32" is just a snapshot of our repository on some arbitrary day, not an officially supported stable version. Some projects use the term "nightly build". > I am also doing the upgrade from 3.25 to 4.5. For my application, I need > to replace all original "Error Object" with my customized one (doing in > JavaScript space, not C++). > In 3.25 version, it worked ok. However, after upgrading to 4.5, it is not > working any more! I found turning "snapshot=off" solved this problem. Based > on the observation, I think the default snapshot in 4.5 contains "Error > Object", while in old version (3.25), "Error Object" is not included in the > random snapshot? Is my guess right? Could you help point out where I can > "customize" the snapshot? (Currently I turn off snapshot, and I'm afraid I > have performance issue, sign...). Thanks. > I'm not sure I understand. You shouldn't need to customize the snapshot. Are you modifying V8's source code? What does "it is not working" mean? > On Saturday, November 21, 2015 at 7:26:15 PM UTC+8, Jakob Kummerow wrote: >> >> The purpose of the snapshot is to speed up Isolate and Context creation. >> If you build with snapshot=off, startup will be slower. >> >> (Also, I'm really glad you're moving away from version 3.32.3, which was >> just a random daily snapshot, not suitable for production use.) >> >> On Sat, Nov 21, 2015 at 2:34 AM, Nick Sorrentino <ni...@metavine.com> >> wrote: >> >>> We recently updated our version of V8 from 3.32.3 to 4.5.103.35. We are >>> seeing a major performance impact on Isolate and Context creation. >>> >>> In version 4.1 we were seeing times around 6ms and on 4.5 we are seeings >>> times around 45ms. The code we are benching marking is below. Any >>> guidance here? >>> >>> >>> // Initialise the isolate create parameters >>> >>> Utility::ArrayBufferAllocator allocator; >>> >>> v8::Isolate::CreateParams create_params; >>> >>> create_params.array_buffer_allocator = &allocator; >>> >>> >>> >>> // Create a v8 isolate object >>> >>> v8::Isolate* pIsolate = v8::Isolate::New( create_params ); >>> >>> >>> >>> // Execute the script >>> >>> { >>> >>> // Lock the v8 isolate object >>> >>> v8::Locker oLocker( pIsolate ); >>> >>> >>> >>> // Create a scope for the v8 isolate object >>> >>> v8::Isolate::Scope oIsolateScope( pIsolate ); >>> >>> >>> >>> // Create a handle scope >>> >>> v8::HandleScope oHandleScope( pIsolate ); >>> >>> >>> >>> // Create a template for the global object where we set the >>> built-in global functions. >>> >>> v8::Handle<v8::ObjectTemplate> global = v8::ObjectTemplate::New( >>> pIsolate ); >>> >>> >>> >>> // Bind the functions to the global object template >>> >>> global->Set( v8::String::NewFromUtf8( pIsolate, u8 >>> "VEUnconfigureAnchorContext" ), v8::FunctionTemplate::New( pIsolate, >>> LocalUnconfigureAnchorContext, v8::External::New( pIsolate, >>> m_pScriptObject ) ) ); >>> //more methods added here (~200) >>> >>> // Create a new context based on the global object template >>> >>> v8::Handle<v8::Context> oContext = v8::Context::New( pIsolate, >>> NULL, global ); >>> >>> } >>> >>> >>> How We are making version 3.32 >>> make library=shared soname_version=3.32.3 i18nsupport=off >>> OUTDIR=../$(DEPS_BUILD_BASE_DIR)v8 x64.release >>> >>> How We are making version 4.5 >>> >>> make library=shared soname_version=4.5.103 i18nsupport=off snapshot=off >>> OUTDIR=../$(DEPS_BUILD_BASE_DIR)v8 x64.release >>> >>> >>> >>> Any advice our guidance would be greatly appreciated. >>> >>> -- >>> -- >>> v8-users mailing list >>> v8-u...@googlegroups.com >>> http://groups.google.com/group/v8-users >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-users+u...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > -- > v8-users mailing list > v8-users@googlegroups.com > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to the Google Groups > "v8-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-users+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.