The improvements are with respect to serializing stack traces, that is if
you access {.stack} on an error object. Performance for error creation,
that is walking the stack and collecting frames, regressed slightly since
we do some more work upfront now.On Thu, Feb 13, 2020 at 11:33 AM Wilfried Goesgens <wi...@arangodb.com> wrote: > No, > I wanted to demonstrate the Improvements of the New V8 release, found the > stacktraces prominent on the changelog lists; Thus I created a test to give > me some estimates, and was disappointed with my findings ;-) If there is a > better way to test it, please give me an example. > Cheers, > Willi > > Am Mittwoch, 12. Februar 2020 22:43:12 UTC+1 schrieb Dan Elphick: >> >> When I ran the test in d8 (unfortunately I didn't keep the old binaries >> around so can't quickly verify) I saw at most a 10% difference between 7.1 >> vs 7.9. >> >> Is this manifesting somewhere other than in your micro benchmark? Because >> this looks to be pretty much the worst case scenario, the function doesn't >> do anything except construct an Error object which requires constructing a >> stack trace and it needs to build 9 frames each time, but unless this is >> causing a problem in real code, I'm not sure how much attention it warrants. >> >> On Wed, 12 Feb 2020 at 14:42, Wilfried Gösgens <doth...@gmail.com> wrote: >> >>> This 600x slowdown was inside of arangosh due to pasting - its not there >>> anymore in the numbers of my previous post - sorry I didn't mention it >>> explicitely. >>> >>> However, if you compare the numbers of my previous post, there still is >>> an offset of ~40% which I'd still call significant? >>> >>> -- >>> -- >>> v8-users mailing list >>> v8-u...@googlegroups.com >>> http://groups.google.com/group/v8-users >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-u...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/v8-users/cdeb797d-c2e3-4a8d-924f-cd484159e18f%40googlegroups.com >>> <https://groups.google.com/d/msgid/v8-users/cdeb797d-c2e3-4a8d-924f-cd484159e18f%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > -- > v8-users mailing list > v8-users@googlegroups.com > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to the Google Groups > "v8-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-users+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-users/0e87e1f2-1814-4c93-8057-f2982b77f20c%40googlegroups.com > <https://groups.google.com/d/msgid/v8-users/0e87e1f2-1814-4c93-8057-f2982b77f20c%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/CACswSC1xws%3D_GFUASpg8Y0cDO6Cny%3D1F2CpwGOuL3sFYJpLCsw%40mail.gmail.com.
