With your patches and a patch for ICU (see attach.) I was able to build the version 8.4.
Thanks! Am Montag, 27. Juli 2020 17:10:50 UTC+2 schrieb Rodrigo Hernandez: > > See the patches I posted on this thread > <https://groups.google.com/forum/#!topic/v8-users/TgJIIIWsy20>, you need > to add "-Wno-range-loop-construct" and maybe "-Wno-invalid-offsetof" to > your compilation flags if you're using clang. > The patches are for the 8.3 branch head, but the changes needed are about > the same. > > On Monday, July 27, 2020 at 3:45:28 AM UTC-6, Hans Maier wrote: >> >> Hi, >> >> I'm trying to compile the branch head of 8.4 under windows using msvc. >> Unfortunatly I get compile errors: >> >> ../../src/compiler/backend/register-allocator-verifier.cc(355,19): error: >> loop variable 'pair' creates a copy from type 'const std::pair<const >> v8::internal::compiler::InstructionOperand, >> v8::internal::compiler::Assessment *>' [-Werror,-Wrange-loop-construct] >> for (const auto pair : map()) { >> ^ >> ../../src/compiler/backend/register-allocator-verifier.cc(355,8): note: >> use reference type 'const std::pair<const >> v8::internal::compiler::InstructionOperand, >> v8::internal::compiler::Assessment *> &' to prevent copying >> for (const auto pair : map()) { >> ^~~~~~~~~~~~~~~~~ >> & >> 1 error generated. >> >> For complete log see attach >> >> Any ideas where the error comes from are appreciated, >> thanks. >> >> >cl >> Microsoft (R) C/C++-Optimierungscompiler Version 19.16.27042 für x86 >> >> >git log -n 1 >> commit 483421e9549adbf4a65d54d43fbffb250a577e5c (HEAD, tag: 8.4.371.22, >> origin/8.4-lkgr, branch-heads/8.4) >> >> >> >gn gen out/x64-win.release --args="is_debug=false target_cpu=\"x64\" >> v8_target_cpu=\"x64\" use_goma=false is_clang=true v8_static_library=false >> is_component_build=true use_custom_libcxx=false >> v8_untrusted_code_mitigations=true" >> >> >>ninja -C out/x64-win.release >> > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/6140a4f2-c879-475d-98a5-8aa0dc4a29cco%40googlegroups.com.
diff --git a/source/i18n/numrange_impl.h b/source/i18n/numrange_impl.h index 8f4c8a40..182b747c 100644 --- a/source/i18n/numrange_impl.h +++ b/source/i18n/numrange_impl.h @@ -1,4 +1,4 @@ -// © 2018 and later: Unicode, Inc. and others. +// © 2018 and later: Unicode, Inc. and others. // License & terms of use: http://www.unicode.org/copyright.html #include "unicode/utypes.h" @@ -109,5 +109,7 @@ class NumberRangeFormatterImpl : public UMemory { } // namespace number U_NAMESPACE_END +template struct U_I18N_API std::atomic< U_NAMESPACE_QUALIFIER number::impl::NumberRangeFormatterImpl*>; + #endif //__SOURCE_NUMRANGE_TYPES_H__ #endif /* #if !UCONFIG_NO_FORMATTING */ diff --git a/source/i18n/unicode/numberrangeformatter.h b/source/i18n/unicode/numberrangeformatter.h index 4d436a76..cae4c655 100644 --- a/source/i18n/unicode/numberrangeformatter.h +++ b/source/i18n/unicode/numberrangeformatter.h @@ -1,4 +1,4 @@ -// © 2018 and later: Unicode, Inc. and others. +// © 2018 and later: Unicode, Inc. and others. // License & terms of use: http://www.unicode.org/copyright.html #ifndef __NUMBERRANGEFORMATTER_H__ @@ -194,8 +194,6 @@ class NumberRangeFormatterImpl; } // namespace icu::number U_NAMESPACE_END -template struct U_I18N_API std::atomic< U_NAMESPACE_QUALIFIER number::impl::NumberRangeFormatterImpl*>; - U_NAMESPACE_BEGIN namespace number { // icu::number #endif
