No problem, I am glad it worked out for you. On Tuesday, July 28, 2020 at 1:29:52 AM UTC-6, Hans Maier wrote: > > With your patches and a patch for ICU (see attach.) I was able to build > the version 8.4. > > Thanks! > > Am Montag, 27. Juli 2020 17:10:50 UTC+2 schrieb Rodrigo Hernandez: >> >> See the patches I posted on this thread >> <https://groups.google.com/forum/#!topic/v8-users/TgJIIIWsy20>, you need >> to add "-Wno-range-loop-construct" and maybe "-Wno-invalid-offsetof" to >> your compilation flags if you're using clang. >> The patches are for the 8.3 branch head, but the changes needed are about >> the same. >> >> On Monday, July 27, 2020 at 3:45:28 AM UTC-6, Hans Maier wrote: >>> >>> Hi, >>> >>> I'm trying to compile the branch head of 8.4 under windows using msvc. >>> Unfortunatly I get compile errors: >>> >>> ../../src/compiler/backend/register-allocator-verifier.cc(355,19): >>> error: loop variable 'pair' creates a copy from type 'const std::pair<const >>> v8::internal::compiler::InstructionOperand, >>> v8::internal::compiler::Assessment *>' [-Werror,-Wrange-loop-construct] >>> for (const auto pair : map()) { >>> ^ >>> ../../src/compiler/backend/register-allocator-verifier.cc(355,8): note: >>> use reference type 'const std::pair<const >>> v8::internal::compiler::InstructionOperand, >>> v8::internal::compiler::Assessment *> &' to prevent copying >>> for (const auto pair : map()) { >>> ^~~~~~~~~~~~~~~~~ >>> & >>> 1 error generated. >>> >>> For complete log see attach >>> >>> Any ideas where the error comes from are appreciated, >>> thanks. >>> >>> >cl >>> Microsoft (R) C/C++-Optimierungscompiler Version 19.16.27042 für x86 >>> >>> >git log -n 1 >>> commit 483421e9549adbf4a65d54d43fbffb250a577e5c (HEAD, tag: 8.4.371.22, >>> origin/8.4-lkgr, branch-heads/8.4) >>> >>> >>> >gn gen out/x64-win.release --args="is_debug=false target_cpu=\"x64\" >>> v8_target_cpu=\"x64\" use_goma=false is_clang=true v8_static_library=false >>> is_component_build=true use_custom_libcxx=false >>> v8_untrusted_code_mitigations=true" >>> >>> >>ninja -C out/x64-win.release >>> >>
-- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/e25bf6b1-8079-47f1-a145-ee6f60377d55o%40googlegroups.com.
