On Fri, 20 Mar 2026 14:12:12 GMT, Marc Chevalier <[email protected]> wrote:
>> Benoît Maillard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment > > test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestMissingOptCastSpeculative.java > line 74: > >> 72: iload(2). >> 73: aconst_null(). >> 74: aastore(). > > If I understand well, it's doing `va[index] = null` and it's expected to > throw? Maybe worth adding a little comment for people who don't enjoy > assemblies as much as I do? Yes, if we do `va[index] = null` in `test` the generated IR is a little different and we don't hit the assert. This is all extracted (and reduced) from `TestLWorld.java`. I have added a comment ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2242#discussion_r2973515203
