> These functions cast oops to arrayOop without first checking that the `obj` 
> argument is an array. It turns out that TestIntrinsics.java sends in 
> non-array objects.
> 
> I found this when I worked on something else and changed 
> `obj->is_null_free_array()` to `obj->klass()->is_null_free_array_klass()`, 
> and the latter asserted because `obj` was a String and not an array.

Stefan Karlsson has updated the pull request incrementally with one additional 
commit since the last revision:

  Change the functions to take an Object[] as the argument

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2261/files
  - new: https://git.openjdk.org/valhalla/pull/2261/files/36ebcbbd..8406165e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2261&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2261&range=00-01

  Stats: 72 lines in 9 files changed: 1 ins; 23 del; 48 mod
  Patch: https://git.openjdk.org/valhalla/pull/2261.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2261/head:pull/2261

PR: https://git.openjdk.org/valhalla/pull/2261

Reply via email to