On Mon, 30 Mar 2026 22:42:11 GMT, Bill Huang <[email protected]> wrote:
>> The idea is to implement the **ValueClass** annotation that can be used in >> test code to allow to run the same tests with and without --enable-preview. >> >> This annotation should be used to mark value classes. >> >> The new jtreg test compilation and execution mode that uses javac plugin to >> process classes during compilation. This plugin change classes with >> **ValueClass** annotation to value classes. >> By default, the annotation doesn't have any impact on the tests. >> >> Here are the work items: >> >> 1. Create ValueClass annotation. >> 2. Create a javac plugin, ValueClassPlugin, that implements a TaskListener >> to mark a class as a value class during the PARSE phase. >> 3. Build the ValueClass plugin. >> 4. Pass a new plugin option, -Xplugin:ValueClassPlugin, to enable the plugin >> and enable preview. > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > Add back VALUE_CLASS_PLUGIN flag and enable it automatically when > --enable-preview is passed via jtreg options. test/jdk/java/util/Collections/AddAll.java line 31: > 29: * @key randomness > 30: * @library /test/lib > 31: * @build jdk.test.lib.valueclass.AsValueClass Is it needed? I thought that it should be built automatically. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2253#discussion_r3012612825
