On Fri, 20 Mar 2026 22:40:53 GMT, Chen Liang <[email protected]> wrote:
>> Hi all, >> >> This change eliminates more box cache usages when running with >> `--enable-preview`: >> * The majority of the change is contributed by @xmas92 who disabled CDS >> loading an archived cache. >> * There's an autobox cache cast in C2 that needed to be disabled. >> >> Notably, this change does not prevent the `XXXCache`'s `cache` variables >> from being CDS archived. This is due to the fact that the infrastructure is >> common to preview and non-preview mode, and the code complexity is not >> justifiable when the cost is storing five `null`s. Instead, it is ensured >> that the cache is never read from. >> >> Testing: tiers 1-4. > > What does this really solve? This doesn't identify the sites that incorrectly > initialized these caches. This doesn't remove the C2 recognition of special > wrapper arrays. Why do we need this? Since HS RT & JIT is happy, @liach are you content enough with the Java changes? ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2249#issuecomment-4175461659
