@caspernorrbin Started cleaning up markWord.hpp with 
https://github.com/openjdk/valhalla/pull/2238, but while reviewing that patch I 
realized that it would be good to make a number of simplifications before 
proceeding. I talked that through with Casper and @Arraying. Those changes are 
now done, and I've taken a pass through markWord.hpp to follow in the spirit of 
what Casper did and some of the things we three talked about.

I've also made updates and clarifications to the comments.

One main thing about this proposal is that I want it to be crystal clear when 
we talk about bit and when we talk about a mask. To make sure that the bit 
constants only ever refers to one bit I've added helpers to verify that this is 
the case.

-------------

Commit messages:
 - Fix x86
 - Move age_mask_in_place
 - Swap order of bit description
 - [lworld] Review and rewrite of markWord.hpp

Changes: https://git.openjdk.org/valhalla/pull/2310/files
  Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=2310&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8374147
  Stats: 85 lines in 4 files changed: 26 ins; 14 del; 45 mod
  Patch: https://git.openjdk.org/valhalla/pull/2310.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2310/head:pull/2310

PR: https://git.openjdk.org/valhalla/pull/2310

Reply via email to