On Wed, 8 Apr 2026 12:31:03 GMT, Stefan Karlsson <[email protected]> wrote:
> @caspernorrbin Started cleaning up markWord.hpp with > https://github.com/openjdk/valhalla/pull/2238, but while reviewing that patch > I realized that it would be good to make a number of simplifications before > proceeding. I talked that through with Casper and @Arraying. Those changes > are now done, and I've taken a pass through markWord.hpp to follow in the > spirit of what Casper did and some of the things we three talked about. > > I've also made updates and clarifications to the comments. > > One main thing about this proposal is that I want it to be crystal clear when > we talk about bit and when we talk about a mask. To make sure that the bit > constants only ever refers to one bit I've added helpers to verify that this > is the case. This reads a lot better than before! I like and agree with the new naming scheme. Thank you for doing this work. ------------- Marked as reviewed by cnorrbin (no project role). PR Review: https://git.openjdk.org/valhalla/pull/2310#pullrequestreview-4076231265
