On Fri, 17 Apr 2026 12:41:28 GMT, Thomas Schatzl <[email protected]> wrote:
>> Hi all, >> >> please review this change that extends G1 eager reclaim to large flat >> arrays. >> >> This is mostly just a generalization ion of the existing mechanism, there is >> not much new about it. >> >> Testing: gha, tier1-5 >> >> Thanks, >> Thomas >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Thomas Schatzl has updated the pull request incrementally with two additional > commits since the last revision: > > - Update src/hotspot/share/gc/g1/g1FullCollector.cpp > - Update src/hotspot/share/gc/g1/g1ConcurrentMark.inline.hpp > > Co-authored-by: Stefan Karlsson <[email protected]> Looks good. Didn't review the test. FWIW, one thing I realized is that `return obj->is_array() && !obj->is_array_with_oops();` reads and decodes the Klass* three times (IIRC). Hopefully, the compiler will combine those into one read/decode. It could be worth double-checking. ------------- Marked as reviewed by stefank (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2255#pullrequestreview-4128829954
