On Wed, 22 Apr 2026 13:50:36 GMT, Roland Westrelin <[email protected]> wrote:

> When doing late inlining, `GraphKit::access_load_at()` may be called
> to populate an `InlineTypeNode`. When it executes, it, sometimes,
> causes the `map` used by the `GraphKit` instance to change. When that
> happens, `CallGenerator::do_late_inline_helper()` continues execution
> with an outdated `map` which causes issues during parsing.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

src/hotspot/share/opto/callGenerator.cpp line 706:

> 704:         // GraphKit::access_load_at() may be called from 
> InlineTypeNode::make_from_multi() and it may change the map
> 705:         // that arg_kit uses.
> 706:         map = arg_kit.map();

Should we have a single `GraphKit` that is used to collect all arguments? What 
if we have 2 arguments that affect the map of `arg_kit`, it seems that it will 
cause the `map` to diverge, am I right?

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2356#discussion_r3124693325

Reply via email to