On Wed, 22 Apr 2026 14:29:45 GMT, Quan Anh Mai <[email protected]> wrote:
>> Roland Westrelin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> extra test > > src/hotspot/share/opto/callGenerator.cpp line 706: > >> 704: // GraphKit::access_load_at() may be called from >> InlineTypeNode::make_from_multi() and it may change the map >> 705: // that arg_kit uses. >> 706: map = arg_kit.map(); > > Should we have a single `GraphKit` that is used to collect all arguments? > What if we have 2 arguments that affect the map of `arg_kit`, it seems that > it will cause the `map` to diverge, am I right? Something like the test I just pushed? It seems to work ok. `GraphKit::SavedState::SavedState()` and `GraphKit::SavedState::~SavedState()` is where the new map originates from and AFAICT, `SavedState` wires things up so it doesn't matter if we have multiple changes in map. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2356#discussion_r3129183066
