On Wed, 22 Apr 2026 13:50:19 GMT, David Beaumont <[email protected]> wrote:
>> make/jdk/src/classes/build/tools/valhalla/valuetypes/GenValueClasses.java
>> line 128:
>>
>>> 126: Optional<? extends TypeElement> valueClassAnnotation =
>>> 127: getAnnotation(annotations,
>>> MIGRATED_VALUE_CLASS_ANNOTATION);
>>> 128: if (valueClassAnnotation.isPresent()) {
>>
>> I would expect a call to RoundEnvironment.getElementsAnnotatedWith() to be
>> used in this method. Is there a reason for avoiding that?
>>
>> If you need to operate on the _files_ containing the annotated types, you
>> could use Elements.getFileObjectOf to create a set of them.
>
> I'm not super familiar with APs, so it's probably just that. Let me have a
> look...
Hmm, it is used inside the method I call slightly further down (~L145).
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2180#discussion_r3125009066
