On Thu, 23 Apr 2026 11:51:36 GMT, Tobias Hartmann <[email protected]> wrote:
>> Marc Chevalier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comment: do_acmp -> InlineKlass::Members
>
> src/hotspot/share/oops/inlineKlass.hpp line 207:
>
>> 205: int null_marker_offset_in_payload() const { return
>> null_marker_offset() - payload_offset(); }
>> 206:
>> 207: int64_t fast_acmp_offset() const {
>> return members()._fast_acmp_offset; }
>
> Indentation is off here.
Is it a coincidence that this is 2 characters too long, and there is exactly 2
more characters in `fast_acmp_offset` than in `fast_acmp_mask`? Once again,
copy-paste-jutsu.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2353#discussion_r3130605128
