On Tue, 28 Apr 2026 12:06:39 GMT, Paul Hübner <[email protected]> wrote:
>> Joel Sikström has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove _has_embedded_oops > > test/hotspot/jtreg/runtime/valhalla/inlinetypes/ContendedFlatFieldOopMap.java > line 32: > >> 30: * @test ContendedFlatFieldOopMap >> 31: * @library /test/lib >> 32: * @requires vm.flagless > > This will ignore other GCs than the default (likely G1). Is that intentional? I'll change this to `@requires vm.gc != "Z"`, since ZGC is the only GC that will provoke the earlier bug, but the test can really be run with any GC and should pass. > test/hotspot/jtreg/runtime/valhalla/inlinetypes/ContendedFlatFieldOopMap.java > line 66: > >> 64: Asserts.assertNotEquals(ref.get(), null); >> 65: >> 66: System.gc(); > > Is there any reason we prefer `System.gc` over `WhiteBox`' GC? No, just a habit. I'll change to `WhiteBox.fullGC()`, since that is a bit stronger. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2371#discussion_r3154625841 PR Review Comment: https://git.openjdk.org/valhalla/pull/2371#discussion_r3154619774
