On Wed, 29 Apr 2026 08:28:11 GMT, Paul Hübner <[email protected]> wrote:

>> Joel Sikström has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Test enhancement
>
> test/hotspot/jtreg/runtime/valhalla/inlinetypes/ContendedFlatFieldOopMap.java 
> line 39:
> 
>> 37:  * @enablePreview
>> 38:  * @run driver jdk.test.lib.helpers.ClassFileInstaller 
>> jdk.test.whitebox.WhiteBox
>> 39:  * @run main/othervm -XX:-RestrictContended
> 
> Nit: it might be good to guard against this being set:
> `@requires vm.opt.RestrictContended == null`
> Or maybe even:
> `@requires vm.opt.RestrictContended == null | vm.opt.RestrictContended == 
> "false"`

Good point. Fixed in latest commit.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2371#discussion_r3159618261

Reply via email to