On Tue, 12 May 2026 14:04:34 GMT, Tobias Hartmann <[email protected]> wrote:
>> The problem is that we are pushing casts through InlineTypeNodes without >> checking if their types are even compatible. In dead parts of the graph, >> when a type check wasn't folded yet, the type of the CheckCastPP can be >> completely unrelated to the type of the InlineTypeNode. Pushing the cast >> through leads to an incorrect type being used further below in the graph and >> subsequent failures. >> >> I tried hard to come up with standalone reproducer for this but failed. It >> reproduces reliably with replay compilation though. >> >> Thanks, >> Tobias >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Tobias Hartmann has updated the pull request incrementally with one > additional commit since the last revision: > > Fixed check That makes sense. If I understand well, we just find the inconsistency and leave it there. Can we be more active and remove the dead parts of the graph already? Or can we somehow make sure these nodes are disappearing "soon"? Maybe I'm biased toward early node killing... Unfortunate we don't have a test, but I know the feeling... ------------- Marked as reviewed by mchevalier (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2423#pullrequestreview-4273644127
