On Tue, 12 May 2026 14:04:34 GMT, Tobias Hartmann <[email protected]> wrote:

>> The problem is that we are pushing casts through InlineTypeNodes without 
>> checking if their types are even compatible. In dead parts of the graph, 
>> when a type check wasn't folded yet, the type of the CheckCastPP can be 
>> completely unrelated to the type of the InlineTypeNode. Pushing the cast 
>> through leads to an incorrect type being used further below in the graph and 
>> subsequent failures.
>> 
>> I tried hard to come up with standalone reproducer for this but failed. It 
>> reproduces reliably with replay compilation though.
>> 
>> Thanks,
>> Tobias
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Tobias Hartmann has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fixed check

The fix looks good, thanks for your work.

-------------

Marked as reviewed by qamai (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2423#pullrequestreview-4274210837

Reply via email to