On Mon, 11 May 2026 20:39:43 GMT, Bill Huang <[email protected]> wrote:
> **Tests Updated**
>
> **TEST.groups**
> Add java/util/Collections to valhalla_adopted.
>
> **test/lib**
> Introduces a shared jdk.test.lib.valueclass.Tuple value class (two-int,
> Comparable, with equals/hashCode).
>
> **AddAll.java**
> Broaden the existing @AsValueClass Point path to cover the same collection
> types (LinkedList, HashSet, LinkedHashSet) and verify final contents using
> value equality.
>
> **AsLifoQueue.java**
> Add a parallel LIFO-order block with value-class elements exercising the same
> add/peek/remove/poll operations.
>
> **BigBinarySearch.java**
> Add a minimal comparable value class backed by the existing sparse-list
> structure to verify huge binary search without new edge cases.
>
> **BinarySearchNullComparator.java**
> Add a comparable value-class list and confirm that a null comparator falls
> back to natural ordering correctly.
>
> **CheckedListBash.java**
> Add a checkedList(…, V.class) helper covering insert,
> contains/indexOf/toArray, and wrong-type raw-add rejection.
>
> **CheckedListReplaceAll.java**
> Verify that replaceAll on a checked value list accepts correct-type results
> and throws ClassCastException for wrong-type results.
>
> **CheckedMapBash.java**
> Add a value-key/value checked-map smoke path covering
> put/containsKey/containsValue/equals and raw wrong-type put rejection.
>
> **CheckedMapReplaceAll.java**
> Verify that Map.replaceAll on a checked value map accepts correct-type values
> and rejects wrong-type values.
>
> **CheckedQueue.java**
> Add a checkedQueue(…, V.class) block covering add/peek and wrong-type raw-add
> rejection.
>
> **CheckedSetBash.java**
> Add a checked value-class set helper covering add/contains/remove, equality
> with a copy, and wrong-type raw-add rejection.
>
> **Disjoint.java**
> Add overlapping and non-overlapping value-class collections to confirm that
> disjoint uses value-state equality.
>
> **Enum.java**
> Add a value-class Vector<V> and assert that Collections.list produces an
> equal list in original order.
>
> **EnumerationAsIterator.java**
> Add one value-class data-provider case using
> Collections.enumeration(Arrays.asList(…)) and verify element delivery.
>
> **FindSubList.java**
> Add value-class source and target lists and assert correct first and last
> sublist indices.
>
> **Frequency.java**
> Add a value-class list with repeated separately constructed equal values and
> confirm that frequency counts by value-state equality.
>
> **NCopies.java**
> Add value-class versions of the indexOf/lastIndexOf/equals/hashCode/reversed
> checks using a repeated value element.
>
> **NullComparato...
test/lib/jdk/test/lib/valueclass/Tuple.java line 34:
> 32: */
> 33: @AsValueClass
> 34: public class Tuple implements Comparable<Tuple> {
Let's declare this class final.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2421#discussion_r3223600162
