On Fri, 15 May 2026 21:18:33 GMT, Matias Saavedra Silva <[email protected]> 
wrote:

> This patch adds detailed printing for flat arrays in the AOTMapLogger and 
> allows proper printing of embedded oops. Verified with tie 1-5 tests.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

src/hotspot/share/cds/aotMapLogger.cpp line 552:

> 550: // fake oops for logging.
> 551: class AOTMapLogger::FakeOop {
> 552: protected:

Why does _iter need to be protected?

src/hotspot/share/cds/aotMapLogger.cpp line 555:

> 553:   OopDataIterator* _iter;
> 554: 
> 555: private:

If _iter can be private, this line can be deleted, as the default permission is 
`private`.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2444#discussion_r3268891475
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2444#discussion_r3268896033

Reply via email to