On Wed, 20 May 2026 21:53:07 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> This patch adds detailed printing for flat arrays in the AOTMapLogger and >> allows proper printing of embedded oops. Verified with tie 1-5 tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matias Saavedra Silva has updated the pull request incrementally with one > additional commit since the last revision: > > Added copyright > Looks good overall. I added more tests. See > [iklam@aa5da4e](https://github.com/iklam/valhalla/commit/aa5da4e3d258a5571f46957341ac3e2edf4c2887) > > * Use `-Xlog:aot+map=trace,aot+map+oops=trace` to print the hex values of all > objects, so it's easier to check the human-readable output against the actual > values > * Use values like `0xaaaa` in the test case, so it's easy to scan for them in > the map file > * Add tests for nested flattening > > I also noticed that the output for `boxArray` doesn't say anything about null > markers, even though there is space allocated for the `0x00000001` slots. Is > this correct? > > ``` > 0x00000000fff99d00: @@ Object (0xfff99d00) [Ljava.lang.Integer; length: 3 > - klass: 'java/lang/Integer'[] 0x0000000800169bb0 > - Index 0 offset 16: > - private final value 'value' (fields 0x00000000) 'I' @16 43690 (0x0000aaaa) > - Index 1 offset 24: > - private final value 'value' (fields 0x00000000) 'I' @16 48059 (0x0000bbbb) > - Index 2 offset 32: > - private final value 'value' (fields 0x00000000) 'I' @16 52428 (0x0000cccc) > 0x00000000fff99d00: 00000201 00000000 00169bb0 00000003 0000aaaa 00000001 > 0000bbbb 00000001 ................................ > 0x00000000fff99d20: 0000cccc 00000001 > ........ > ``` The null marker should be there but it only seems to be printed when we have nested flat fields, like in the Wrapper array. I think this should be printed for all cases of inline fields. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2444#issuecomment-4511177166
