On Wed, 27 May 2026 14:57:47 GMT, Tobias Hartmann <[email protected]> wrote:
> The problem is that we are running out of metadata space and after the call > to `ObjArrayKlass::klass_with_properties` in `ciObjArrayKlass::make_impl` we > are not checking for OOMEs. We should check `HAS_PENDING_EXCEPTION` like we > do just above. There's also a place in the LIR assembler that now needs to > check if an unloaded klass is returned, similar to here: > > https://github.com/openjdk/valhalla/blob/4c23f0ed5d6a89cd1e7ab8550b367bca296a9f30/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp#L1212-L1214 > > Thanks, > Tobias > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Looks consistent to me. Reminds me in places @fparain fixed where I forgot such a check. Would be nice to have a more systematic way to make it less likely to forget. I don't have an idea, right now, tho. ------------- Marked as reviewed by mchevalier (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2478#pullrequestreview-4373681639
