> The problem is that we are running out of metadata space and after the call 
> to `ObjArrayKlass::klass_with_properties` in `ciObjArrayKlass::make_impl` we 
> are not checking for OOMEs. We should check `HAS_PENDING_EXCEPTION` like we 
> do just above. There's also a place in the LIR assembler that now needs to 
> check if an unloaded klass is returned, similar to here:
> 
> https://github.com/openjdk/valhalla/blob/4c23f0ed5d6a89cd1e7ab8550b367bca296a9f30/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp#L1212-L1214
> 
> Thanks,
> Tobias
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Tobias Hartmann has updated the pull request incrementally with four additional 
commits since the last revision:

 - Fixing again ..
 - Merge branch 'JDK-8385473' of github.com:TobiHartmann/valhalla into 
JDK-8385473
 - Removed unstable test
 - Remove unstable test (again)

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2478/files
  - new: https://git.openjdk.org/valhalla/pull/2478/files/a0bd7170..0944a83d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2478&range=03
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2478&range=02-03

  Stats: 156 lines in 1 file changed: 0 ins; 156 del; 0 mod
  Patch: https://git.openjdk.org/valhalla/pull/2478.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2478/head:pull/2478

PR: https://git.openjdk.org/valhalla/pull/2478

Reply via email to