On Wed, 3 Jun 2026 20:57:13 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LocalProxyVarsGen.java
>> line 120:
>>
>>> 118: * we need to recover those now and add them to this
>>> constructor
>>> 119: */
>>> 120: if (fieldsReadInPrologue.get(classDecl) != null) {
>>
>> We never clear this entry up, right?
>
> I wonder if it would be cleaner to first collect all the stuff that needs
> patching (and clear entries in the map) and then pass them to the
> addLocalProxiesFor method -- that method already accepts a Set anyway
I'm also noticing (but that's just an observation) that maybe symbols could be
used as map keys too -- e.g. maybe we don't really need trees?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2507#discussion_r3351944274
