On Thu, 4 Jun 2026 03:33:58 GMT, Chen Liang <[email protected]> wrote:
>> Vicente Romero has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LocalProxyVarsGen.java > line 124: > >> 122: earlyReads = fieldsReadInPrologue.get(classDecl); >> 123: fieldsReadInPrologue.remove(classDecl); >> 124: } > > Suggestion: > > Set<Symbol> earlyReads = fieldsReadInPrologue.remove(classDecl); > > > However I wonder if this removing for one constructor is right - we might > need to duplicate initializers to multiple constructors. yes, it is not right to remove it here, we need it for other constructors. We can remove once the class has been completely generated ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2507#discussion_r3354735759
