On Wed, 3 Jun 2026 22:06:55 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> The preview compilation of modules ignore class files supplied to module >> path of normal compilation of modules. This introduces spurious errors when >> a module has preview files and compiles against external class files at the >> same time. >> >> Also removed a useless `ifneq ($(COMPILER), bootjdk)` condition, please >> review the diff without whitespace. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > make/CompileJavaModules.gmk line 143: > >> 141: >> 142: ifneq ($(COMPILER), bootjdk) >> 143: MODULE_PREVIEW_SRC_DIRS := $(call FindModulePreviewSrcDirs, $(MODULE)) > > I'm cleaning this up as part of my work on: > [JDK-8385743](https://bugs.openjdk.org/browse/JDK-8385743) [lworld] > investigate and address build related comments in the Valhalla PR See this gory details comment: https://bugs.openjdk.org/browse/JDK-8385743?focusedId=14884506&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14884506 ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2506#discussion_r3352219780
