On Wed, 3 Jun 2026 18:44:49 GMT, Chen Liang <[email protected]> wrote:
> The preview compilation of modules ignore class files supplied to module path > of normal compilation of modules. This introduces spurious errors when a > module has preview files and compiles against external class files at the > same time. > > Also removed a useless `ifneq ($(COMPILER), bootjdk)` condition, please > review the diff without whitespace. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I'm OK with the changes, but some of them overlap with changes that I'm also making. I can always resync after your integration. One thing I don't understand is: - Licensee builds are broken on macosx-aarch64, macosx-x64 and windows-x64. - The builds appear to work on linux-aarch64 and linux-x64. So I don't understand why the existing code works on linux-aarch64 and linux-x64, but macosx-aarch64, macosx-x64 and windows-x64 need this fix. ------------- Marked as reviewed by dcubed (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2506#pullrequestreview-4423213545
