On Thu, 4 Jun 2026 12:19:02 GMT, Viktor Klang <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Review comments >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> fix/reflect-factory-strict >> - Further cleanup >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> fix/reflect-factory-strict >> - Prevent reflection factory hacking strict init > > src/java.base/share/classes/jdk/internal/value/ValueClass.java line 169: > >> 167: /// Returns whether a class or interface declares strict instance >> fields. >> 168: /// This does not include inherited instance fields. >> 169: public static boolean hasStrictInstanceField(Class<?> cl) { > > Is this intended as a long-term solution? Yes, since this is only meaningfully used by legacy serialization, I think this ugly approach is acceptable. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2350#discussion_r3355959223
