On Thu, 4 Jun 2026 12:04:30 GMT, Viktor Klang <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Message updated
>
> test/jdk/java/io/Serializable/valueObjects/SimpleValueGraphs.java line 367:
>
>> 365: var obj = new ValueExt();
>> 366: var ex = Assertions.assertThrows(InvalidClassException.class,
>> () -> serialize(obj));
>> 367: Assertions.assertEquals("SimpleValueGraphs$ValueExt; cannot
>> serialize value class", ex.getMessage());
>
> Shouldn't this error message say "externalize" rather than "serialize" (based
> off of the test name)
I don't think we need distinct serialize/externalize messages for
Externalizable: this distinction was arbitrary from an earlier implementation.
The true distinction is migrated wrappers versus all other non-writeReplace
Serializable value classes.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2326#discussion_r3355971716
