On Thu, 4 Jun 2026 12:05:53 GMT, Viktor Klang <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Message updated
>
> test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line
> 113:
>
>> 111: for (var f :
>> NonSerializableStrictPoint.class.getDeclaredFields()) {
>> 112: assertTrue(f.isStrictInit(), f.getName());
>> 113: }
>
> I think it would be good to also validate that we are indeed seeing the
> fields (i.e. assert that we see "x" and "y")
That would be an assertion on the `getDeclaredFields` facility. I am more
concerned about this annotation processing because the `@driver` clause is more
likely to be accidentally omitted or have typos in test directives and becomes
hard to debug. There is no such problem with `Class.getDeclaredFields` so I
don't think field omissions is a problem.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2326#discussion_r3356582348
