On Sat, 6 Jun 2026 00:17:07 GMT, Ioi Lam <[email protected]> wrote: >> Casper Norrbin has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains seven commits: >> >> - static null-restricted check, new test, other feedback >> - Merge branch 'lworld' into systemdict-nullrestricted-loading >> - create symbol only when logging >> - Merge branch 'lworld' into systemdict-nullrestricted-loading >> - Validate archived inline field dependencies without LoadableDescriptors >> - re-add failed marker >> - removed forced loading for nullrestricted > > test/hotspot/jtreg/runtime/cds/appcds/ArchivedFieldMetadataMismatchTest.java > line 132: > >> 130: for (String className : classNames) { >> 131: TestCommon.stripLoadableDescriptors(testClasses, >> jarClasses, className); >> 132: } > > Can you explain why this is necessary? > > If I disable this, the test case fails.
This code doesn't seem necessary. I have simplified this test case and removed this part. Please see my version at: https://github.com/iklam/valhalla/commit/a836109cb8b7c4edc77136937eff8e7c7358a83b ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2409#discussion_r3366677983
