On Fri, 5 Jun 2026 21:23:01 GMT, Ioi Lam <[email protected]> wrote: >> Casper Norrbin has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains seven commits: >> >> - static null-restricted check, new test, other feedback >> - Merge branch 'lworld' into systemdict-nullrestricted-loading >> - create symbol only when logging >> - Merge branch 'lworld' into systemdict-nullrestricted-loading >> - Validate archived inline field dependencies without LoadableDescriptors >> - re-add failed marker >> - removed forced loading for nullrestricted > > This patch is needed to avoid failures in tier 4 testing > > $ git diff > diff --git a/test/hotspot/jtreg/TEST.groups b/test/hotspot/jtreg/TEST.groups > index 0ef426ef4ce..8ce8204d138 100644 > --- a/test/hotspot/jtreg/TEST.groups > +++ b/test/hotspot/jtreg/TEST.groups > @@ -538,6 +538,7 @@ hotspot_aot_classlinking = \ > -runtime/cds/appcds/aotCode \ > -runtime/cds/appcds/aotFlags \ > -runtime/cds/appcds/aotProfile \ > + -runtime/cds/appcds/ArchivedFieldMetadataMismatchTest.java \ > -runtime/cds/appcds/BadBSM.java \ > -runtime/cds/appcds/cacheObject/ArchivedFlatArrayTest.java \ > -runtime/cds/appcds/cacheObject/ArchiveHeapTestClass.java \
Thanks for the quick feedback! I have pushed an update that updates various comments to be more clear, and changed `try_preload_from_loadable_descriptors` to also use `check_shared_class_dependency`. I also Cherry-picked in @iklam's simplified test version, which is much cleaner while covering the same behavior. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2409#issuecomment-4649395661
