On Tue, 9 Jun 2026 19:44:30 GMT, Frederic Parain <[email protected]> wrote:
>> Here's a patch adding argument validation to the factories for the special >> arrays. >> It also aligns the semantic of these factories with other ways to create >> arrays with respect to the initialization state of the element type. >> Some compiler tests needed adjustments because of the new code shape of the >> factories. >> >> Thank you. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Frederic Parain has updated the pull request incrementally with one > additional commit since the last revision: > > Fix indentations and spaces Compiler change looks good to me. src/hotspot/share/opto/parse2.cpp line 101: > 99: if (!array_type->is_flat()) { > 100: assert(array_type->is_flat() || > control()->in(0)->as_If()->is_flat_array_check(&_gvn), "Should be found"); > 101: // Storing to a non-flat array, casting array to not flat. This is an array load, not store. ------------- Marked as reviewed by qamai (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2435#pullrequestreview-4467125142 PR Review Comment: https://git.openjdk.org/valhalla/pull/2435#discussion_r3387714617
