On Thu, 2 Jul 2026 14:16:32 GMT, Tobias Hartmann <[email protected]> wrote:
>> C2’s Unsafe.get/putFlatValue intrinsic asserts because it does not expect >> the layout `LayoutKind::NULLABLE_NON_ATOMIC_FLAT` added by >> [JDK-8374800](https://bugs.openjdk.org/browse/JDK-8374800). I just fixed the >> assert because the implementation already handles the layout correctly. >> >> Thanks, >> Tobias >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Tobias Hartmann has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'lworld' into JDK-8386499 > - Problem list > - Simplified test > - JDK-8386499 test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestGetFlatValueNullableNonAtomic.java line 56: > 54: OFFSET = U.objectFieldOffset(f); > 55: LAYOUT = U.fieldLayout(f); > 56: Asserts.assertEQ(LAYOUT, 5, "Unexpected layout"); Don't know if it's okay for java code to ever depend on this - Fred recommended against this before, wonder if there's any other hotspot test checking the raw layout value directly. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2619#discussion_r3513796424
