On Thu, 2 Jul 2026 14:23:30 GMT, Chen Liang <[email protected]> wrote:
>> Tobias Hartmann has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge branch 'lworld' into JDK-8386499 >> - Problem list >> - Simplified test >> - JDK-8386499 > > test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestGetFlatValueNullableNonAtomic.java > line 56: > >> 54: OFFSET = U.objectFieldOffset(f); >> 55: LAYOUT = U.fieldLayout(f); >> 56: Asserts.assertEQ(LAYOUT, 5, "Unexpected layout"); > > Don't know if it's okay for java code to ever depend on this - Fred > recommended against this before, wonder if there's any other hotspot test > checking the raw layout value directly. Fair enough, let's just remove it then. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2619#discussion_r3514088176
