On Thu, 16 Jul 2026 15:50:52 GMT, Jaikiran Pai <[email protected]> wrote:
>> src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 125: >> >>> 123: super(name, link.getFileAttributes()); >>> 124: this.file = null; >>> 125: this.link = Objects.requireNonNull(link); >> >> Look at the other constructors: Notice they have `requireNonNull` as an >> intention for what kind of node is constructed and the different state >> contracts of different kinds of nodes. > > I don't follow what you mean. The change proposed in this PR continues to > have the explicit `requireNonNull` check for `link` parameter. For consistency, for the other constructors that do requireNonNull, I think we can move those rNN to be ahead of all the field assignments (including ones that write null). And we can completely drop rNN here. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2649#discussion_r3597865956
