On Thu, 16 Jul 2026 15:33:40 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which reorders a null check in > `ExplodedImage`? While at it, the `isClosable` is made `final` in > `JrtFileSystem` too. > > > > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). > Hello Alan, this came in as a review suggestion in the JEP-401 PR review > [openjdk/jdk#31123 > (comment)](https://github.com/openjdk/jdk/pull/31123#discussion_r3578999129) Okay, so we don't have a bug in the jrtfs implementation that causes this NPE, instead it's that the Objects.requireNonNull is redundant. What you have is okay, alternatively just remove the Objects.requireNonNull because link.getFileAttributes() will give a helpful NPE if we have a bug that causes it to be called with a null link. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2649#issuecomment-5024265393
