On Thu, 16 Jul 2026 19:21:06 GMT, Dan Smith <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Restructuring and rewording >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> doc/lw-vb-ctor-ice >> - Minor ValueBased and InvalidClassException comments > > src/java.base/share/classes/java/lang/doc-files/ValueBased.html line 37: > >> 35: In a future release, they may become value classes (JLS >> 36: {@jls value-objects-8.1.1.5}). >> 37: The compiler and runtime enforce some properties for value-based classes > > If it's appropriate to link to JEPs from javadoc: > > > The compiler and runtime provide <a > href="https://openjdk.org/jeps/390";>warnings</a> > related to the misuse of value-based classes. > > > (Not really "enforcement", and I don't think we need to say anything more > about migration.) If this spec text is supposed to be independent of implementation details like javac and HotSpot warnings, then I just wouldn't mention those features at all. (I think maybe that's the case? This is part of the Java SE specification, after all...) ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2631#discussion_r3598353778
