On Thu, 16 Jul 2026 16:10:38 GMT, Dan Smith <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Restructuring and rewording >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> doc/lw-vb-ctor-ice >> - Minor ValueBased and InvalidClassException comments > > src/java.base/share/classes/java/lang/doc-files/ValueBased.html line 36: > >> 34: {@code java.time.LocalDate}, are <em>value-based</em>. >> 35: The compiler and runtime enforce the value based properties below if it >> is declared >> 36: as {@code value class} and preview features are enabled. > > I made this comment somewhere else, but it may have been dropped: > > Identity classes can be "value-based". It doesn't really make sense to talk > about a "value-based value class"—that's just a value class. Everything in > this file is directed towards identity classes. > > Suggest deleting this sentence. I agree. Did some local revisions; hope you can review the updated version. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2631#discussion_r3597530259
