--------
Dridi Boukelmoune writes:

> My bad, in my mind replying about mmap implied that this was indeed
> about having a convenience functtion to compute the hash of a regular
> file.

Yes, but what do we need that for ?

> Would the attached patch be welcome?

If we have a need, that's pretty much how I would do it.

> Slightly off topic, why have both definitions?
>
>     #define VSHA256_LEN             32
>     #define VSHA256_DIGEST_LENGTH   32

I think I kept it to not break any VMODs which relied on it.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
p...@freebsd.org         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.
_______________________________________________
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Reply via email to